Skip to content

Conversation

@petk
Copy link
Member

@petk petk commented Mar 19, 2019

Hello, since Autoconf 2.53 the AC_INIT call has been refactored and now includes several other optional arguments to make installation experience a bit better.

This patch refactors AC_INIT and PHP version definition a bit.

Reference: https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html

Some more fixes coming up soon...

TODO:

  • Refactor get_version_numbers in win32/build/confutils.js

@petk petk force-pushed the patch-php-version branch 2 times, most recently from f71c22a to 508fffe Compare March 25, 2019 00:04
@petk petk marked this pull request as ready for review March 25, 2019 00:04
@petk petk force-pushed the patch-php-version branch from 508fffe to 6cca1c8 Compare March 26, 2019 00:21
@petk
Copy link
Member Author

petk commented Mar 28, 2019

Merge coming up this weekend or so...

@petk petk self-assigned this Mar 28, 2019
@nikic
Copy link
Member

nikic commented Mar 28, 2019

What is the effect of these changes on configure?

@petk
Copy link
Member Author

petk commented Mar 28, 2019

Obsolete call removed and more info in the ./configure -h output:

  • line that says where to report bugs to ...
  • PHP homepage: ...
  • program version displayed
    etc.

It's how the AC_INIT should be used in today's versions of Autoconf... Basically, catching up to features that were done ~16 years ago :) PHP just didn't refactor this sooner.

@petk petk force-pushed the patch-php-version branch from 6cca1c8 to c952ef2 Compare March 30, 2019 15:17
Since Autoconf 2.53 the AC_INIT call with only a single argument has
been made obsolete and now includes several other optional arguments to
make installation experience a bit better by providing program version
and links to the project in the `./configure -h` output. This patch also
updates win build version.
@petk petk force-pushed the patch-php-version branch from 0452643 to 7d3123e Compare April 3, 2019 00:22
@remicollet
Copy link
Member

@sgolemon please have a look, as this will impact your php-release docker image

@petk
Copy link
Member Author

petk commented Apr 3, 2019

@sgolemon please have a look, as this will impact your php-release docker image

Also makedist has been moved to ./scripts/dev/makedist 😱

Well, what fun it would be if no refactoring would be needed 😊 I can check out what can be done...

@petk
Copy link
Member Author

petk commented Apr 3, 2019

Worth noting, this change is done only on 7.4 branch and up...

@remicollet
Copy link
Member

@petk if you are not aware of it, see https://github.com/sgolemon/php-release which may have some interest for you

@petk petk force-pushed the patch-php-version branch from 7ee2b6d to 1c56000 Compare April 7, 2019 03:45
@petk
Copy link
Member Author

petk commented Apr 7, 2019

Applied via afd52f9 for PHP-7.4 and 8.0+ branches...

@petk petk closed this Apr 7, 2019
@petk petk deleted the patch-php-version branch April 7, 2019 03:55
@nikic
Copy link
Member

nikic commented Apr 9, 2019

As pointed out by @krakjoe this is likely causing build warnings for extensions: https://travis-ci.org/krakjoe/parallel/jobs/517661755#L647

@petk
Copy link
Member Author

petk commented Apr 9, 2019

Hello, let me check it out... Basically there should be some minor adjustments needed I think for the phpize part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants